From hannes at yllr.net Tue Sep 7 14:42:16 2010 From: hannes at yllr.net (Hannes =?iso-8859-1?Q?Sch=FCller?=) Date: Tue, 7 Sep 2010 16:42:16 +0200 Subject: [Vimprobable-users] Improved patch to open several bookmarked urls at once In-Reply-To: <20100818145903.45c0b1ff@workstation> References: <20100815185210.GA2179@aspire.tradesystem.nl> <20100816120218.77957a07@workstation> <20100816172927.GA2826@debian64.tradesystem.nl> <20100818145903.45c0b1ff@workstation> Message-ID: <20100907144215.GB1950@laptop2.lan.localhost> On Wed, Aug 18, 2010 at 02:59:03PM +0200, Hannes Sch?ller wrote: > > See the attached patch. > > I get this: > > main.c: In function ?quit?: > main.c:1166: warning: implicit declaration of function ?flockfile? > main.c:1168: warning: implicit declaration of function ?funlockfile? > main.c: In function ?bookmark?: > main.c:1512: warning: implicit declaration of function ?build_taglist? > main.c: In function ?search_tag?: > main.c:2116: warning: ?return? with no value, in function returning > non-void Fixed those and a few more issues with return values now. New version will be available soon. Hannes -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: Digital signature URL: From hannes at yllr.net Tue Sep 7 14:43:47 2010 From: hannes at yllr.net (Hannes =?iso-8859-1?Q?Sch=FCller?=) Date: Tue, 7 Sep 2010 16:43:47 +0200 Subject: [Vimprobable-users] [PATCH] Implement locking on revive() logic. In-Reply-To: <20100814220525.GA31284@debian> References: <20100814220525.GA31284@debian> Message-ID: <20100907144346.GC1950@laptop2.lan.localhost> I've reverted this for now. The problem is that this is not compatible with the -ansi flag. Not even with -std=c99. I think before we switch standards, we should really discuss the implications concerning portability. Opinions? Hannes -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: Digital signature URL: From matto at matto.nl Wed Sep 8 05:21:07 2010 From: matto at matto.nl (Matto Fransen) Date: Wed, 8 Sep 2010 07:21:07 +0200 Subject: [Vimprobable-users] Improved patch to open several bookmarked urls at once In-Reply-To: <20100907144215.GB1950@laptop2.lan.localhost> References: <20100815185210.GA2179@aspire.tradesystem.nl> <20100816120218.77957a07@workstation> <20100816172927.GA2826@debian64.tradesystem.nl> <20100818145903.45c0b1ff@workstation> <20100907144215.GB1950@laptop2.lan.localhost> Message-ID: <20100908052104.GA1834@aspire.tradesystem.nl> Hi, On Tue, Sep 07, 2010 at 04:42:16PM +0200, Hannes Sch?ller wrote: > Fixed those and a few more issues with return values now. New version > will be available soon. Ah, great. I have just returned from holiday and didn't had any time before that to look into it. Thanx! Cheers, Matto -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: Digital signature URL: From thomas at xteddy.org Wed Sep 8 06:23:30 2010 From: thomas at xteddy.org (Thomas Adam) Date: Wed, 8 Sep 2010 07:23:30 +0100 Subject: [Vimprobable-users] [PATCH] Fix segfault in bookmark tags. Message-ID: <20100908062325.GA355@shuttle.home> Ensure we pre-initialise loop-conditioned variables when building up the tag name, and don't rely on them being assigned default values, which can cause integer overflows. --- utilities.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/utilities.c b/utilities.c index bb64580..d3850e1 100644 --- a/utilities.c +++ b/utilities.c @@ -359,7 +359,7 @@ process_map_line(char *line) { gboolean build_taglist(const Arg *arg, FILE *f) { int k = 0, in_tag = 0; - int t, marker; + int t = 0, marker = 0; char foundtab[MAXTAGSIZE+1]; while (arg->s[k]) { if (!isspace(arg->s[k]) && !in_tag) { 1.6.6.196.g1f735 From thomas at xteddy.org Wed Sep 8 06:30:29 2010 From: thomas at xteddy.org (Thomas Adam) Date: Wed, 8 Sep 2010 07:30:29 +0100 Subject: [Vimprobable-users] [PATCH] Implement locking on revive() logic. In-Reply-To: <20100907144346.GC1950@laptop2.lan.localhost> References: <20100814220525.GA31284@debian> <20100907144346.GC1950@laptop2.lan.localhost> Message-ID: Hi. 2010/9/7 Hannes Sch?ller : > I've reverted this for now. The problem is that this is not compatible > with the -ansi flag. Not even with -std=c99. I think before we switch > standards, we should really discuss the implications concerning > portability. Opinions? Damn -- I thought this was portable enough. Fine, I'll implement locking the proper way at some point. As far as portability is concerned -- you'll need to elaborate what you mean by this. -- Thomas Adam From hannes at yllr.net Wed Sep 8 08:00:15 2010 From: hannes at yllr.net (Hannes =?iso-8859-1?Q?Sch=FCller?=) Date: Wed, 8 Sep 2010 10:00:15 +0200 Subject: [Vimprobable-users] [PATCH] Implement locking on revive() logic. In-Reply-To: References: <20100814220525.GA31284@debian> <20100907144346.GC1950@laptop2.lan.localhost> Message-ID: <20100908080015.GA1925@laptop2.lan.localhost> Hi! On Wed, Sep 08, 2010 at 07:30:29AM +0100, Thomas Adam wrote: > 2010/9/7 Hannes Sch?ller : > > I've reverted this for now. The problem is that this is not compatible > > with the -ansi flag. Not even with -std=c99. I think before we switch > > standards, we should really discuss the implications concerning > > portability. Opinions? > > Damn -- I thought this was portable enough. Fine, I'll implement > locking the proper way at some point. Did you catch the discussion on IRC? It seems flockfile only locks *within the same process*, so it wouldn't achieve the desired effect anyway. > As far as portability is concerned -- you'll need to elaborate what > you mean by this. If we depend on GCC extensions, that's not very portable, is it? I'd think at least that much would be obvious. Hannes -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: Digital signature URL: From thomas at xteddy.org Wed Sep 8 08:09:45 2010 From: thomas at xteddy.org (Thomas Adam) Date: Wed, 8 Sep 2010 09:09:45 +0100 Subject: [Vimprobable-users] [PATCH] Implement locking on revive() logic. In-Reply-To: <20100908080015.GA1925@laptop2.lan.localhost> References: <20100814220525.GA31284@debian> <20100907144346.GC1950@laptop2.lan.localhost> <20100908080015.GA1925@laptop2.lan.localhost> Message-ID: 2010/9/8 Hannes Sch?ller : > If we depend on GCC extensions, that's not very portable, is it? I'd > think at least that much would be obvious. No -- it's certainly not my intention to introduce that. -- Thomas Adam From hannes at yllr.net Wed Sep 8 10:13:10 2010 From: hannes at yllr.net (Hannes =?UTF-8?B?U2Now7xsbGVy?=) Date: Wed, 8 Sep 2010 12:13:10 +0200 Subject: [Vimprobable-users] [PATCH] Fix segfault in bookmark tags. In-Reply-To: <20100908062325.GA355@shuttle.home> References: <20100908062325.GA355@shuttle.home> Message-ID: <20100908121310.0c3d3d60@workstation> Merged, thanks! -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: not available URL: From thomas at xteddy.org Sat Sep 11 10:30:19 2010 From: thomas at xteddy.org (Thomas Adam) Date: Sat, 11 Sep 2010 11:30:19 +0100 Subject: [Vimprobable-users] [PATCH] Check for tagname after ":qt" to fix segfault Message-ID: <20100911103016.GA19355@shuttle.home> Ensure we always check a tag name has been given after issuing a ":qt" command, and if there wasn't one, inform the user. This fixes a segfault where the code always assumed a tag name was present. --- main.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/main.c b/main.c index f8acbaf..3013f5a 100644 --- a/main.c +++ b/main.c @@ -1764,6 +1764,16 @@ search_tag(const Arg * a) { char s[BUFFERSIZE], foundtag[40], url[BUFFERSIZE]; int t, i, intag, k; + if (!tag) { + /* The user must give us something to load up. */ + Arg usage; + usage.i = Error; + usage.s = "Bookmark tag required with this option."; + echo(&usage); + + return TRUE; + } + if (strlen(tag) > MAXTAGSIZE) return FALSE; filename = g_strdup_printf(BOOKMARKS_STORAGE_FILENAME); -- 1.6.6.196.g1f735 From thomas at xteddy.org Sat Sep 11 19:22:19 2010 From: thomas at xteddy.org (Thomas Adam) Date: Sat, 11 Sep 2010 20:22:19 +0100 Subject: [Vimprobable-users] [PATCH] Fix segfault with ":bma" command. Message-ID: <20100911192215.GA16925@shuttle.home> When the tagging option was introduced, this broke the :bma command by always assuming there would be a tag option after the name --- but previously no option after this command meant the current URL. This patch restores that behaviour. --- main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/main.c b/main.c index f8acbaf..2c29788 100644 --- a/main.c +++ b/main.c @@ -1505,7 +1505,7 @@ bookmark(const Arg *arg) { fprintf(f, "%s", " "); fprintf(f, "%s", title); } - if (strlen(arg->s)) { + if (arg->s && strlen(arg->s)) { build_taglist(arg, f); } fprintf(f, "%s", "\n"); -- 1.6.6.196.g1f735 From hannes at yllr.net Tue Sep 14 12:12:24 2010 From: hannes at yllr.net (Hannes =?iso-8859-1?Q?Sch=FCller?=) Date: Tue, 14 Sep 2010 14:12:24 +0200 Subject: [Vimprobable-users] [PATCH] Check for tagname after ":qt" to fix segfault In-Reply-To: <20100911103016.GA19355@shuttle.home> References: <20100911103016.GA19355@shuttle.home> Message-ID: <20100914121223.GA17174@laptop2.lan.localhost> Merged, thanks! -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: Digital signature URL: From hannes at yllr.net Tue Sep 14 12:13:26 2010 From: hannes at yllr.net (Hannes =?iso-8859-1?Q?Sch=FCller?=) Date: Tue, 14 Sep 2010 14:13:26 +0200 Subject: [Vimprobable-users] [PATCH] Fix segfault with ":bma" command. In-Reply-To: <20100911192215.GA16925@shuttle.home> References: <20100911192215.GA16925@shuttle.home> Message-ID: <20100914121326.GB17174@laptop2.lan.localhost> Merged, too. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: Digital signature URL: From hannes at yllr.net Wed Sep 22 16:36:03 2010 From: hannes at yllr.net (Hannes =?UTF-8?B?U2Now7xsbGVy?=) Date: Wed, 22 Sep 2010 18:36:03 +0200 Subject: [Vimprobable-users] [PATCH] Better handling of multiple simultaneous downloads In-Reply-To: <1282072685-8784-1-git-send-email-hpdeifel@gmx.de> References: <1282072685-8784-1-git-send-email-hpdeifel@gmx.de> Message-ID: <20100922183603.2d8d0368@workstation> Thanks, Hans-Peter for the patch! I merged it into both branches. And thanks to Thomas for going over the code first. Hannes -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: not available URL: From aplannan2 at gmail.com Fri Sep 24 14:37:01 2010 From: aplannan2 at gmail.com (Andrew Lannan) Date: Fri, 24 Sep 2010 14:37:01 +0000 Subject: [Vimprobable-users] Newbie questions Message-ID: Hi, I recently compiled vimprobable for use with tinycore linux. I am very impressed, thank you to everyone who is helping to develop this browser. Two small questions. After reading the vimprobable home page I am a little nervous asking the first one because it deals with gmail. I do not mind at all the fact that it opens in the HTML view, I actually prefer this stripped down version. However, when I hit Compose Mail to type a new email I cannot type directly into the "To:" field, the "Cc:" field or the "Bcc:" field. The Subject and Message area work well. The fields which do not work usually offer suggestions when you type into them and I wonder if this is part of the problem. The second issue I have been experiencing is with the website for This American Life (www.thisamericanlife.org). With vimprobable2 0.2.3 I could not stream the episodes. When I clicked on "stream episode" I would instead get search (ixquick) results for the javascript player. I don't remember the exact search term. After updating to the current version of vimprobable the page freezes while loading. Thanks in advance for any help. Andy From hannes at yllr.net Fri Sep 24 14:53:58 2010 From: hannes at yllr.net (Hannes =?UTF-8?B?U2Now7xsbGVy?=) Date: Fri, 24 Sep 2010 16:53:58 +0200 Subject: [Vimprobable-users] Newbie questions In-Reply-To: References: Message-ID: <20100924165358.3732dfa0@workstation> Hi! Andrew Lannan wrote: > when I hit Compose Mail to type a new email I cannot type directly > into the "To:" field, the "Cc:" field or the "Bcc:" field. Instead what happens? > The Subject and Message area work well. The fields which do not work > usually offer suggestions when you type into them and I wonder if > this is part of the problem. Sounds like a Javascript problem. Have you enabled it? Have you tried setting the useragent string to something GMail recognises? Many 'problems' seem to stem from the fact that they seem to check the user agent against a whitelist. > The second issue I have been experiencing is with the website for This > American Life (www.thisamericanlife.org). With vimprobable2 0.2.3 I > could not stream the episodes. When I clicked on "stream episode" I > would instead get search (ixquick) results for the javascript player. > I don't remember the exact search term. After updating to the current > version of vimprobable the page freezes while loading. No freeze for me if I click on "Stream Episode" at http://www.thisamericanlife.org/radio-archives/episode/359/life-after-death , for example. However, it simply bounces me back to the same page again, opening it a second time in a new window. I'll have to look into their Javascript code there. Hannes -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: not available URL: From thomas at xteddy.org Fri Sep 24 14:55:28 2010 From: thomas at xteddy.org (Thomas Adam) Date: Fri, 24 Sep 2010 15:55:28 +0100 Subject: [Vimprobable-users] Newbie questions In-Reply-To: References: Message-ID: <20100924145459.GB2931@abacus.soton.smoothwall.net> On Fri, Sep 24, 2010 at 02:37:01PM +0000, Andrew Lannan wrote: > Two small questions. After reading the vimprobable home page I am a > little nervous asking the first one because it deals with gmail. I do > not mind at all the fact that it opens in the HTML view, I actually > prefer this stripped down version. However, when I hit Compose Mail to > type a new email I cannot type directly into the "To:" field, the > "Cc:" field or the "Bcc:" field. The Subject and Message area work > well. The fields which do not work usually offer suggestions when you > type into them and I wonder if this is part of the problem. You need to set PASS-THROUGH mode for this (see ^z). > The second issue I have been experiencing is with the website for This > American Life (www.thisamericanlife.org). With vimprobable2 0.2.3 I 0.2.3? That's an old version. Are you not tracking the Git repository? > could not stream the episodes. When I clicked on "stream episode" I > would instead get search (ixquick) results for the javascript player. > I don't remember the exact search term. After updating to the current > version of vimprobable the page freezes while loading. > Thanks in advance for any help. Ah. Vimprobable2 seems stuck in a busy-loop at some point. Might be JavaScript related; will look when I get home from work. -- Thomas Adam From aplannan2 at gmail.com Fri Sep 24 16:51:17 2010 From: aplannan2 at gmail.com (Andrew Lannan) Date: Fri, 24 Sep 2010 16:51:17 +0000 Subject: [Vimprobable-users] Newbie questions In-Reply-To: <20100924145459.GB2931@abacus.soton.smoothwall.net> References: <20100924145459.GB2931@abacus.soton.smoothwall.net> Message-ID: Hi, Thanks for the replies. How is javascript enabled in vimprobable? When I click on Compose Mail I am in INSERT mode, with the prompt in the "To:" field blinking, however I cannot enter text. I had read about the PASS-THROUGH mode in an earlier thread. I need to press escape to exit INSERT before I can enter PASS-THROUGH in the "To:" field. When I enter PASS-THROUGH the prompt is no longer in the" To:" field, If I click in the field I re-enter INSERT, and can not enter text. Entering PASS-THROUGH in the Subject and Message fields does not require me to hit esc first and does not cause the prompt to disappear. I have also tried setting the useragent (I set it to firefox), with no change in behavior. It is possible that firefox is not a recogized useragent, but I don't know where to get this info. Sorry about bothering you guys with this, and thanks again for your help. Andy On 9/24/10, Thomas Adam wrote: > On Fri, Sep 24, 2010 at 02:37:01PM +0000, Andrew Lannan wrote: >> Two small questions. After reading the vimprobable home page I am a >> little nervous asking the first one because it deals with gmail. I do >> not mind at all the fact that it opens in the HTML view, I actually >> prefer this stripped down version. However, when I hit Compose Mail to >> type a new email I cannot type directly into the "To:" field, the >> "Cc:" field or the "Bcc:" field. The Subject and Message area work >> well. The fields which do not work usually offer suggestions when you >> type into them and I wonder if this is part of the problem. > > You need to set PASS-THROUGH mode for this (see ^z). > >> The second issue I have been experiencing is with the website for This >> American Life (www.thisamericanlife.org). With vimprobable2 0.2.3 I > > 0.2.3? That's an old version. Are you not tracking the Git repository? > >> could not stream the episodes. When I clicked on "stream episode" I >> would instead get search (ixquick) results for the javascript player. >> I don't remember the exact search term. After updating to the current >> version of vimprobable the page freezes while loading. >> Thanks in advance for any help. > > Ah. Vimprobable2 seems stuck in a busy-loop at some point. Might be > JavaScript related; will look when I get home from work. > > -- Thomas Adam > From hpdeifel at gmx.de Fri Sep 24 17:03:48 2010 From: hpdeifel at gmx.de (Hans-Peter Deifel) Date: Fri, 24 Sep 2010 19:03:48 +0200 Subject: [Vimprobable-users] Newbie questions In-Reply-To: References: Message-ID: <20100924170348.GA8755@hurz> Hi, > When I clicked on "stream episode" I would instead get search > (ixquick) results for the javascript player. I don't remember the > exact search term. There are two related problems that could cause this: 1. We intercept requests for opening a page in a new window and don't evaluate the javascript in links like "javascript:blah()". Uzbl solves this by creating a new WebView and letting the new page load just long enough to know what it's URL is. Then the WebView is destroyed and the URL is passed to a new uzbl instance. 2. Even when such a javascript link has the current frame as target, it could be that the javascript code itself tries to open a new window. This should work fine, when the link was activated via keyboard. But if it was clicked on, webview_open_in_new_window_cb will be called. As this callback has no access to the requested URL, it just opens the link that the mouse pointer hovered over last, which is "javascript:..". (This is mostly from memory, so it could be slightly different) Regards, HP From tyler at monkeypox.org Thu Sep 30 05:21:20 2010 From: tyler at monkeypox.org (R. Tyler Croy) Date: Wed, 29 Sep 2010 22:21:20 -0700 Subject: [Vimprobable-users] [PATCH 0/8] A few extensions to vimprobable2 Message-ID: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> Forgive me for the patch spam to the list, I've got a few patches to the latest release of vimprobable2 that I'm currentlly using. I recognize that some of the patches are likely not going to be desired by most folks but I'm including them anyways (for posterity or some nonsense) It is also worth noting that the user-agent patch exists to make sure vimprobable2 works out of the box with many banking and otherwise poorly developed websites that do miserable jobs at browser capability detection. (this is all up on github at: ) -- R. Tyler Croy (5): Instal manpages into the appropriate directory in ${PREFIX} Adding an ignore file Change the default search engine and add encrypted Google Search Make hints a bit more readable with black on yellow Use a more Chrome-looking user-agent to help vimprobable2 work with more sites Add Apture's detached search by default Bump the font-size to make vimprobable2 a bit easier to read on bigger screens Disable Java by default .gitignore | 4 ++++ Makefile | 4 ++-- apture.js | 28 ++++++++++++++++++++++++++++ config.h | 21 ++++++++++++++------- hinting.js | 8 ++++---- js-merge-helper.pl | 7 +++++++ main.c | 3 +++ 7 files changed, 62 insertions(+), 13 deletions(-) create mode 100644 .gitignore create mode 100644 apture.js From tyler at monkeypox.org Thu Sep 30 05:21:21 2010 From: tyler at monkeypox.org (R. Tyler Croy) Date: Wed, 29 Sep 2010 22:21:21 -0700 Subject: [Vimprobable-users] [PATCH 1/8] Instal manpages into the appropriate directory in ${PREFIX} In-Reply-To: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> Message-ID: <1285824088-30272-2-git-send-email-tyler@monkeypox.org> --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index f59fa28..12b29ed 100644 --- a/Makefile +++ b/Makefile @@ -16,7 +16,7 @@ LDFLAGS += `pkg-config --libs $(LIBS)` PREFIX ?= /usr/local BINDIR ?= $(PREFIX)/bin -MANDIR ?= $(PREFIX)/man +MANDIR ?= $(PREFIX)/share/man # Mode bits for normal not executable files FMOD ?= 0644 # Mode bits for directories -- 1.7.1 From tyler at monkeypox.org Thu Sep 30 05:21:22 2010 From: tyler at monkeypox.org (R. Tyler Croy) Date: Wed, 29 Sep 2010 22:21:22 -0700 Subject: [Vimprobable-users] [PATCH 2/8] Adding an ignore file In-Reply-To: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> Message-ID: <1285824088-30272-3-git-send-email-tyler@monkeypox.org> --- .gitignore | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..ac6223d --- /dev/null +++ b/.gitignore @@ -0,0 +1,4 @@ +*.o +vimprobable2 +javascript.h +*.d -- 1.7.1 From tyler at monkeypox.org Thu Sep 30 05:21:23 2010 From: tyler at monkeypox.org (R. Tyler Croy) Date: Wed, 29 Sep 2010 22:21:23 -0700 Subject: [Vimprobable-users] [PATCH 3/8] Change the default search engine and add encrypted Google Search In-Reply-To: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> Message-ID: <1285824088-30272-4-git-send-email-tyler@monkeypox.org> --- config.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/config.h b/config.h index ef538d7..0584355 100644 --- a/config.h +++ b/config.h @@ -6,7 +6,7 @@ */ /* general settings */ -char startpage[241] = "http://www.vimprobable.org/"; +char startpage[241] = "http://www.duckduckgo.com/"; char useragent[120] = "Vimprobable2/0.9.4.0"; static const gboolean enablePlugins = TRUE; /* TRUE keeps plugins enabled */ @@ -80,8 +80,8 @@ static const int searchoptions = CaseInsensitive | Wrapping; /* search engines */ static Searchengine searchengines[] = { - { "i", "http://ixquick.com/do/metasearch.pl?query=%s" }, - { "s", "https://ssl.scroogle.org/cgi-bin/nbbwssl.cgi?Gw=%s" }, + { "d", "https://duckduckgo.com/?q=%s" }, + { "gg", "https://encrypted.google.com/search?hl=en&source=hp&ie=ISO-8859-1&q=%s&aq=f&aqi=&oq=&gs_rfai=" }, { "w", "https://secure.wikimedia.org/wikipedia/en/w/index.php?title=Special%%3ASearch&search=%s&go=Go" }, { "wd", "https://secure.wikimedia.org/wikipedia/de/w/index.php?title=Special%%3ASearch&search=%s&go=Go" }, }; -- 1.7.1 From tyler at monkeypox.org Thu Sep 30 05:21:24 2010 From: tyler at monkeypox.org (R. Tyler Croy) Date: Wed, 29 Sep 2010 22:21:24 -0700 Subject: [Vimprobable-users] [PATCH 4/8] Make hints a bit more readable with black on yellow In-Reply-To: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> Message-ID: <1285824088-30272-5-git-send-email-tyler@monkeypox.org> IMHO white-on-red is too jarring with regards to contrast, making it more difficult to see --- hinting.js | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hinting.js b/hinting.js index 55c10b3..da217b4 100644 --- a/hinting.js +++ b/hinting.js @@ -55,9 +55,9 @@ function vimprobable_show_hints(inputText) { hint.style.position = "absolute"; hint.style.left = leftpos + "px"; hint.style.top = toppos + "px"; - hint.style.background = "red"; - hint.style.color = "#fff"; - hint.style.font = "bold 10px monospace"; + hint.style.background = "yellow"; + hint.style.color = "#000"; + hint.style.font = "bold 14px monospace"; hint.style.zIndex = "99"; var text = document.createTextNode(vimprobable_j + 1); hint.appendChild(text); @@ -67,7 +67,7 @@ function vimprobable_show_hints(inputText) { vimprobable_backgrounds[vimprobable_j] = elem.style.background; /* make the link black to ensure it's readable */ elem.style.color = "#000"; - elem.style.background = "#ff0"; + elem.style.background = "#fff"; vimprobable_j++; } i = 0; -- 1.7.1 From tyler at monkeypox.org Thu Sep 30 05:21:25 2010 From: tyler at monkeypox.org (R. Tyler Croy) Date: Wed, 29 Sep 2010 22:21:25 -0700 Subject: [Vimprobable-users] [PATCH 5/8] Use a more Chrome-looking user-agent to help vimprobable2 work with more sites In-Reply-To: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> Message-ID: <1285824088-30272-6-git-send-email-tyler@monkeypox.org> Too many important sites are using crappy browser detection, causing vimprobable2 to have issues running their JS --- config.h | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/config.h b/config.h index 0584355..a60a60e 100644 --- a/config.h +++ b/config.h @@ -6,8 +6,14 @@ */ /* general settings */ -char startpage[241] = "http://www.duckduckgo.com/"; -char useragent[120] = "Vimprobable2/0.9.4.0"; +char startpage[241] = "https://www.duckduckgo.com/"; +/* + * Disabling the default user-agent so more sites work properly. We'll pretend + * to be Google Chrome right now + * + * char useragent[120] = "Vimprobable2/0.9.2.1"; + */ +char useragent[120] = "Mozilla/5.0 (X11; U; Linux x86_64; en-US) AppleWebKit/534.7 (Vimprobable2/0.9.4.0, like Gecko) Chrome/7.0.514.0 Safari/534.7"; static const gboolean enablePlugins = TRUE; /* TRUE keeps plugins enabled */ /* appearance */ -- 1.7.1 From tyler at monkeypox.org Thu Sep 30 05:21:26 2010 From: tyler at monkeypox.org (R. Tyler Croy) Date: Wed, 29 Sep 2010 22:21:26 -0700 Subject: [Vimprobable-users] [PATCH 6/8] Add Apture's detached search by default In-Reply-To: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> Message-ID: <1285824088-30272-7-git-send-email-tyler@monkeypox.org> This is kind of a jerry-rigged version of the Apture Highlights plugin for Chrome. This should probably be generalized to be easier to turn off via userscripts support or something similar --- Makefile | 2 +- apture.js | 28 ++++++++++++++++++++++++++++ js-merge-helper.pl | 7 +++++++ main.c | 2 ++ 4 files changed, 38 insertions(+), 1 deletions(-) create mode 100644 apture.js diff --git a/Makefile b/Makefile index 12b29ed..32170a3 100644 --- a/Makefile +++ b/Makefile @@ -34,7 +34,7 @@ all: $(TARGET) -include $(DEPS) main.o: javascript.h -javascript.h: input-focus.js hinting.js +javascript.h: input-focus.js hinting.js apture.js perl ./js-merge-helper.pl $(TARGET): $(OBJ) diff --git a/apture.js b/apture.js new file mode 100644 index 0000000..b05eb7b --- /dev/null +++ b/apture.js @@ -0,0 +1,28 @@ +(function(s) { + var uri = String(window.location).toLowerCase(); + var parts = uri.split('.'); + if (parts.length > 0) { + var suffix = parts[parts.length - 1]; + if ( (suffix == 'png') || (suffix == 'jpg') || + (suffix == 'jpeg') || (suffix == 'gif') ) { + return; + } + } + + if (!window.apture) { + window.apture_onload = function() { + apture.barTitle = "vimprobable!"; + apture.amazonAffiliateTag="unethicalblog-20"; + /* Disable Ctrl-C and the bar from rolling in */ + apture.capabilities = 2080; + apture.auto = 1; + apture.initTMM(); + }; + s.src = 'http://www.apture.com/js/aptureTmmBookmarklet.js'; + document.body.appendChild(s); + } + else { + apture.initTMM && apture.initTMM(); + } +})(document.createElement('script')) + diff --git a/js-merge-helper.pl b/js-merge-helper.pl index 050d871..ea0b592 100644 --- a/js-merge-helper.pl +++ b/js-merge-helper.pl @@ -23,11 +23,18 @@ $_ = do { local $/; }; close(JSFILE); my $js_input = escape_c_string($_); +open(JSFILE, "apture.js") or die "Failed to open file: $!"; +$_ = do { local $/; }; +close(JSFILE); +my $apture = escape_c_string($_); + open(HFILE, ">javascript.h") or die "Failed to open javascript.h: $!"; print HFILE "#define JS_SETUP_HINTS "; printf HFILE "\"%s\"\n", $js_hints; print HFILE "#define JS_SETUP_INPUT_FOCUS "; printf HFILE "\"%s\"\n", $js_input; +print HFILE "#define APTURE_JS "; +printf HFILE "\"%s\"\n", $apture; close(HFILE); exit; diff --git a/main.c b/main.c index 81e1f78..32f4131 100644 --- a/main.c +++ b/main.c @@ -181,11 +181,13 @@ webview_load_committed_cb(WebKitWebView *webview, WebKitWebFrame *frame, gpointe void webview_load_finished_cb(WebKitWebView *webview, WebKitWebFrame *frame, gpointer user_data) { Arg a = { .i = Silent, .s = JS_SETUP_INPUT_FOCUS }; + Arg apture = { .i = Silent, .s = APTURE_JS }; if (HISTORY_MAX_ENTRIES > 0) history(); update_state(); script(&a); + script(&apture); } static gboolean -- 1.7.1 From tyler at monkeypox.org Thu Sep 30 05:21:27 2010 From: tyler at monkeypox.org (R. Tyler Croy) Date: Wed, 29 Sep 2010 22:21:27 -0700 Subject: [Vimprobable-users] [PATCH 7/8] Bump the font-size to make vimprobable2 a bit easier to read on bigger screens In-Reply-To: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> Message-ID: <1285824088-30272-8-git-send-email-tyler@monkeypox.org> --- config.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/config.h b/config.h index a60a60e..f9a3869 100644 --- a/config.h +++ b/config.h @@ -23,12 +23,12 @@ char sslbgcolor[] = "#b0ff00"; /* background co char sslcolor[] = "#000000"; /* color for status bar with SSL url */ /* normal, warning, error */ -static const char *urlboxfont[] = { "monospace normal 8", "monospace normal 8", "monospace bold 8"}; +static const char *urlboxfont[] = { "monospace normal 9", "monospace normal 9", "monospace bold 9"}; static const char *urlboxcolor[] = { NULL, "#ff0000", "#ffffff" }; static const char *urlboxbgcolor[] = { NULL, NULL, "#ff0000" }; /* normal, error */ -static const char *completionfont[] = { "monospace normal 8", "monospace bold 8" }; +static const char *completionfont[] = { "monospace normal 9", "monospace bold 9" }; /* topborder color */ static const char *completioncolor[] = { "#000000", "#ff00ff", "#000000" }; /* current row background */ @@ -37,7 +37,7 @@ static const char *completionbgcolor[] = { "#ffffff", "#ffffff", #define COMPLETION_TAG_OPEN "" #define COMPLETION_TAG_CLOSE "" -static const char statusfont[] = "monospace bold 8"; /* font for status bar */ +static const char statusfont[] = "monospace bold 9"; /* font for status bar */ #define ENABLE_HISTORY_INDICATOR #define ENABLE_INCREMENTAL_SEARCH #define ENABLE_GTK_PROGRESS_BAR -- 1.7.1 From tyler at monkeypox.org Thu Sep 30 05:21:28 2010 From: tyler at monkeypox.org (R. Tyler Croy) Date: Wed, 29 Sep 2010 22:21:28 -0700 Subject: [Vimprobable-users] [PATCH 8/8] Disable Java by default In-Reply-To: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> Message-ID: <1285824088-30272-9-git-send-email-tyler@monkeypox.org> Who uses Java applets? All Java (in vimprobable2 at least) seems to do is destabilize the browser --- config.h | 1 + main.c | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/config.h b/config.h index f9a3869..2ee49b5 100644 --- a/config.h +++ b/config.h @@ -15,6 +15,7 @@ char startpage[241] = "https://www.duckduckgo.com/"; */ char useragent[120] = "Mozilla/5.0 (X11; U; Linux x86_64; en-US) AppleWebKit/534.7 (Vimprobable2/0.9.4.0, like Gecko) Chrome/7.0.514.0 Safari/534.7"; static const gboolean enablePlugins = TRUE; /* TRUE keeps plugins enabled */ +static const gboolean enableJava = FALSE; /* FALSE disables Java applets (recommended) */ /* appearance */ char statusbgcolor[] = "#000000"; /* background color for status bar */ diff --git a/main.c b/main.c index 32f4131..6db5d84 100644 --- a/main.c +++ b/main.c @@ -2065,6 +2065,7 @@ setup_settings() { g_object_set((GObject*)settings, "default-font-size", DEFAULT_FONT_SIZE, NULL); g_object_set((GObject*)settings, "enable-scripts", enablePlugins, NULL); g_object_set((GObject*)settings, "enable-plugins", enablePlugins, NULL); + g_object_set((GObject*)settings, "enable-java-applet", enableJava, NULL); filename = g_strdup_printf(USER_STYLESHEET); filename = g_strdup_printf("file://%s", filename); g_object_set((GObject*)settings, "user-stylesheet-uri", filename, NULL); -- 1.7.1 From thomas at xteddy.org Thu Sep 30 05:48:41 2010 From: thomas at xteddy.org (Thomas Adam) Date: Thu, 30 Sep 2010 06:48:41 +0100 Subject: [Vimprobable-users] [PATCH 1/8] Instal manpages into the appropriate directory in ${PREFIX} In-Reply-To: <1285824088-30272-2-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-2-git-send-email-tyler@monkeypox.org> Message-ID: <20100930054838.GB15934@shuttle.home> On Wed, Sep 29, 2010 at 10:21:21PM -0700, R. Tyler Croy wrote: > --- > Makefile | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/Makefile b/Makefile > index f59fa28..12b29ed 100644 > --- a/Makefile > +++ b/Makefile > @@ -16,7 +16,7 @@ LDFLAGS += `pkg-config --libs $(LIBS)` > > PREFIX ?= /usr/local > BINDIR ?= $(PREFIX)/bin > -MANDIR ?= $(PREFIX)/man > +MANDIR ?= $(PREFIX)/share/man > # Mode bits for normal not executable files > FMOD ?= 0644 > # Mode bits for directories This looks fine to me. -- Thomas Adam -- "Deep in my heart I wish I was wrong. But deep in my heart I know I am not." -- Morrissey ("Girl Least Likely To" -- off of Viva Hate.) From thomas at xteddy.org Thu Sep 30 05:49:40 2010 From: thomas at xteddy.org (Thomas Adam) Date: Thu, 30 Sep 2010 06:49:40 +0100 Subject: [Vimprobable-users] [PATCH 2/8] Adding an ignore file In-Reply-To: <1285824088-30272-3-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-3-git-send-email-tyler@monkeypox.org> Message-ID: <20100930054938.GC15934@shuttle.home> On Wed, Sep 29, 2010 at 10:21:22PM -0700, R. Tyler Croy wrote: > --- > .gitignore | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > create mode 100644 .gitignore > > diff --git a/.gitignore b/.gitignore > new file mode 100644 > index 0000000..ac6223d > --- /dev/null > +++ b/.gitignore > @@ -0,0 +1,4 @@ > +*.o > +vimprobable2 > +javascript.h > +*.d *.o Please squash that in with a v2 rollout of this patch. -- Thomas Adam -- "Deep in my heart I wish I was wrong. But deep in my heart I know I am not." -- Morrissey ("Girl Least Likely To" -- off of Viva Hate.) From thomas at xteddy.org Thu Sep 30 05:51:50 2010 From: thomas at xteddy.org (Thomas Adam) Date: Thu, 30 Sep 2010 06:51:50 +0100 Subject: [Vimprobable-users] [PATCH 3/8] Change the default search engine and add encrypted Google Search In-Reply-To: <1285824088-30272-4-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-4-git-send-email-tyler@monkeypox.org> Message-ID: <20100930055148.GD15934@shuttle.home> On Wed, Sep 29, 2010 at 10:21:23PM -0700, R. Tyler Croy wrote: > --- > config.h | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/config.h b/config.h > index ef538d7..0584355 100644 > --- a/config.h > +++ b/config.h > @@ -6,7 +6,7 @@ > */ > > /* general settings */ > -char startpage[241] = "http://www.vimprobable.org/"; > +char startpage[241] = "http://www.duckduckgo.com/"; > char useragent[120] = "Vimprobable2/0.9.4.0"; > static const gboolean enablePlugins = TRUE; /* TRUE keeps plugins enabled */ > > @@ -80,8 +80,8 @@ static const int searchoptions = CaseInsensitive | Wrapping; > > /* search engines */ > static Searchengine searchengines[] = { > - { "i", "http://ixquick.com/do/metasearch.pl?query=%s" }, > - { "s", "https://ssl.scroogle.org/cgi-bin/nbbwssl.cgi?Gw=%s" }, > + { "d", "https://duckduckgo.com/?q=%s" }, > + { "gg", "https://encrypted.google.com/search?hl=en&source=hp&ie=ISO-8859-1&q=%s&aq=f&aqi=&oq=&gs_rfai=" }, > { "w", "https://secure.wikimedia.org/wikipedia/en/w/index.php?title=Special%%3ASearch&search=%s&go=Go" }, > { "wd", "https://secure.wikimedia.org/wikipedia/de/w/index.php?title=Special%%3ASearch&search=%s&go=Go" }, > }; I'm not in favour of augmenting this at all. What is duckduckgo anyway? What rationale is there for including google as a search engine here? The Vimprobable homepage explains why it's not included; encrypted or otherwise. I appreciate that at the moment, adding in searchengines is a static, and it requires recompilation, but I don't think this patch needs including in Vimprobable. -- Thomas Adam -- "Deep in my heart I wish I was wrong. But deep in my heart I know I am not." -- Morrissey ("Girl Least Likely To" -- off of Viva Hate.) From thomas at xteddy.org Thu Sep 30 05:52:44 2010 From: thomas at xteddy.org (Thomas Adam) Date: Thu, 30 Sep 2010 06:52:44 +0100 Subject: [Vimprobable-users] [PATCH 4/8] Make hints a bit more readable with black on yellow In-Reply-To: <1285824088-30272-5-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-5-git-send-email-tyler@monkeypox.org> Message-ID: <20100930055243.GE15934@shuttle.home> On Wed, Sep 29, 2010 at 10:21:24PM -0700, R. Tyler Croy wrote: > IMHO white-on-red is too jarring with regards to contrast, > making it more difficult to see > --- > hinting.js | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hinting.js b/hinting.js > index 55c10b3..da217b4 100644 > --- a/hinting.js > +++ b/hinting.js > @@ -55,9 +55,9 @@ function vimprobable_show_hints(inputText) { > hint.style.position = "absolute"; > hint.style.left = leftpos + "px"; > hint.style.top = toppos + "px"; > - hint.style.background = "red"; > - hint.style.color = "#fff"; > - hint.style.font = "bold 10px monospace"; > + hint.style.background = "yellow"; > + hint.style.color = "#000"; > + hint.style.font = "bold 14px monospace"; > hint.style.zIndex = "99"; > var text = document.createTextNode(vimprobable_j + 1); > hint.appendChild(text); > @@ -67,7 +67,7 @@ function vimprobable_show_hints(inputText) { > vimprobable_backgrounds[vimprobable_j] = elem.style.background; > /* make the link black to ensure it's readable */ > elem.style.color = "#000"; > - elem.style.background = "#ff0"; > + elem.style.background = "#fff"; > vimprobable_j++; > } > i = 0; This the sort of thing you can fix up locally. IMO, the defaults are fine. I'd be inclined to reject this. -- Thomas Adam -- "Deep in my heart I wish I was wrong. But deep in my heart I know I am not." -- Morrissey ("Girl Least Likely To" -- off of Viva Hate.) From thomas at xteddy.org Thu Sep 30 05:54:26 2010 From: thomas at xteddy.org (Thomas Adam) Date: Thu, 30 Sep 2010 06:54:26 +0100 Subject: [Vimprobable-users] [PATCH 5/8] Use a more Chrome-looking user-agent to help vimprobable2 work with more sites In-Reply-To: <1285824088-30272-6-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-6-git-send-email-tyler@monkeypox.org> Message-ID: <20100930055425.GF15934@shuttle.home> On Wed, Sep 29, 2010 at 10:21:25PM -0700, R. Tyler Croy wrote: > Too many important sites are using crappy browser detection, causing vimprobable2 > to have issues running their JS Please just use: set useragent=foo bar baz In your ~/.config/vimprobable/vimprobablerc file. Note that this comes up from time-to-time on this list as to why it's not changed. I prefer the config file approach. Hence, I'm in favour of rejecting this. -- Thomas Adam -- "Deep in my heart I wish I was wrong. But deep in my heart I know I am not." -- Morrissey ("Girl Least Likely To" -- off of Viva Hate.) From thomas at xteddy.org Thu Sep 30 05:56:11 2010 From: thomas at xteddy.org (Thomas Adam) Date: Thu, 30 Sep 2010 06:56:11 +0100 Subject: [Vimprobable-users] [PATCH 7/8] Bump the font-size to make vimprobable2 a bit easier to read on bigger screens In-Reply-To: <1285824088-30272-8-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-8-git-send-email-tyler@monkeypox.org> Message-ID: <20100930055610.GG15934@shuttle.home> On Wed, Sep 29, 2010 at 10:21:27PM -0700, R. Tyler Croy wrote: > --- > config.h | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) Horses for courses. I don't have a strong opinion on this, but it's likely just git history noise if it's accepted. ;P -- Thomas Adam -- "Deep in my heart I wish I was wrong. But deep in my heart I know I am not." -- Morrissey ("Girl Least Likely To" -- off of Viva Hate.) From thomas at xteddy.org Thu Sep 30 05:57:33 2010 From: thomas at xteddy.org (Thomas Adam) Date: Thu, 30 Sep 2010 06:57:33 +0100 Subject: [Vimprobable-users] [PATCH 8/8] Disable Java by default In-Reply-To: <1285824088-30272-9-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-9-git-send-email-tyler@monkeypox.org> Message-ID: <20100930055732.GH15934@shuttle.home> On Wed, Sep 29, 2010 at 10:21:28PM -0700, R. Tyler Croy wrote: > Who uses Java applets? All Java (in vimprobable2 at least) seems to do > is destabilize the browser This isn't a rationale, it's a personal preference. In favour of rejecting this. -- Thomas Adam -- "Deep in my heart I wish I was wrong. But deep in my heart I know I am not." -- Morrissey ("Girl Least Likely To" -- off of Viva Hate.) From thomas at xteddy.org Thu Sep 30 06:02:58 2010 From: thomas at xteddy.org (Thomas Adam) Date: Thu, 30 Sep 2010 07:02:58 +0100 Subject: [Vimprobable-users] [PATCH 0/8] A few extensions to vimprobable2 In-Reply-To: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> Message-ID: <20100930060257.GI15934@shuttle.home> Hello -- On Wed, Sep 29, 2010 at 10:21:20PM -0700, R. Tyler Croy wrote: > > Forgive me for the patch spam to the list, I've got a few patches to the > latest release of vimprobable2 that I'm currentlly using. > > I recognize that some of the patches are likely not going to be desired > by most folks but I'm including them anyways (for posterity or some nonsense) Well, some of them are useful, such as the Makefile patches, and the gitignore patch. Please see my relevant replies to those threads. As for the others, I'm advocating to reject them. They can either be controlled via the vimprobablerc file, or fixed up locally by you. Changing the defaults is fine; I've no problem with that [1], but without a rationale -- that is, a bloody good reason, it becomes nothing more than changing the defaults upstream, so you don't have to. :) And I wouldn't want that. :) I appreciate some of the things you have to do must seem like a chore, but for now it will have to stay that way. What you should do, is put some of your patches into a local topic branch and continually rebase it ontop of origin/vimprobable2 and compile that up. That's what I do for all changes I make to config.h which would affect the default. So it's what you should do as well. :) I don't have a comment on "Apture", as I don't care for it. But it will need generalising further if it's to be considered upstream. -- Thomas Adam [1] I already have a patch to make the searchengines configurable via the config file. -- "Deep in my heart I wish I was wrong. But deep in my heart I know I am not." -- Morrissey ("Girl Least Likely To" -- off of Viva Hate.) From tyler at monkeypox.org Thu Sep 30 13:34:26 2010 From: tyler at monkeypox.org (R. Tyler Croy) Date: Thu, 30 Sep 2010 06:34:26 -0700 Subject: [Vimprobable-users] [PATCH 2/8] Adding an ignore file In-Reply-To: <20100930054938.GC15934@shuttle.home> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-3-git-send-email-tyler@monkeypox.org> <20100930054938.GC15934@shuttle.home> Message-ID: <20100930133425.GB3810@kiwi.local> On Thu, 30 Sep 2010, Thomas Adam wrote: > On Wed, Sep 29, 2010 at 10:21:22PM -0700, R. Tyler Croy wrote: > > --- > > .gitignore | 4 ++++ > > 1 files changed, 4 insertions(+), 0 deletions(-) > > create mode 100644 .gitignore > > > > diff --git a/.gitignore b/.gitignore > > new file mode 100644 > > index 0000000..ac6223d > > --- /dev/null > > +++ b/.gitignore > > @@ -0,0 +1,4 @@ > > +*.o > > +vimprobable2 > > +javascript.h > > +*.d > > *.o > > Please squash that in with a v2 rollout of this patch. I'm confused, the first line of the file is '*.o'? - R. Tyler Croy -------------------------------------- GitHub: http://github.com/rtyler Twitter: http://twitter.com/agentdero -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: not available URL: From tyler at monkeypox.org Thu Sep 30 13:37:10 2010 From: tyler at monkeypox.org (R. Tyler Croy) Date: Thu, 30 Sep 2010 06:37:10 -0700 Subject: [Vimprobable-users] [PATCH 8/8] Disable Java by default In-Reply-To: <20100930055732.GH15934@shuttle.home> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-9-git-send-email-tyler@monkeypox.org> <20100930055732.GH15934@shuttle.home> Message-ID: <20100930133710.GC3810@kiwi.local> On Thu, 30 Sep 2010, Thomas Adam wrote: > On Wed, Sep 29, 2010 at 10:21:28PM -0700, R. Tyler Croy wrote: > > Who uses Java applets? All Java (in vimprobable2 at least) seems to do > > is destabilize the browser > > This isn't a rationale, it's a personal preference. > > In favour of rejecting this. What if this was changed to be a proper setting cohnfigurable via :set? In my usage of vimprobable2, any time a Java applet is loaded into the WebView the browser SIGSEGVs something nasty, thus the patch. I can understand why you might not want Java to be disabled by default (Chrome doesn't disable it either), but IMHO it should be an accessible setting at least from the Vimprobablerc Would you accept a patch with an rc setting and defaulting to java enabled? - R. Tyler Croy -------------------------------------- GitHub: http://github.com/rtyler Twitter: http://twitter.com/agentdero -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: not available URL: From tyler at monkeypox.org Thu Sep 30 13:46:39 2010 From: tyler at monkeypox.org (R. Tyler Croy) Date: Thu, 30 Sep 2010 06:46:39 -0700 Subject: [Vimprobable-users] [PATCH 0/8] A few extensions to vimprobable2 In-Reply-To: <20100930060257.GI15934@shuttle.home> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <20100930060257.GI15934@shuttle.home> Message-ID: <20100930134639.GD3810@kiwi.local> On Thu, 30 Sep 2010, Thomas Adam wrote: > Hello -- > > On Wed, Sep 29, 2010 at 10:21:20PM -0700, R. Tyler Croy wrote: > > > > Forgive me for the patch spam to the list, I've got a few patches to the > > latest release of vimprobable2 that I'm currentlly using. > > > > I recognize that some of the patches are likely not going to be desired > > by most folks but I'm including them anyways (for posterity or some nonsense) > > Well, some of them are useful, such as the Makefile patches, and the > gitignore patch. Please see my relevant replies to those threads. > > As for the others, I'm advocating to reject them. They can either be > controlled via the vimprobablerc file, or fixed up locally by you. I'm totally cool with this, I wanted to sent the whole series along for two reasons really: * Wanted to see what you/anybody thought of them in general * Wanted you (upstream) maintainer to be aware of some of the changes/desires that I (userguy) might have with regards to vimprobable2 > I appreciate some of the things you have to do must seem like a chore, but > for now it will have to stay that way. > > What you should do, is put some of your patches into a local topic branch > and continually rebase it ontop of origin/vimprobable2 and compile that up. > That's what I do for all changes I make to config.h which would affect the > default. That's the general plan, I was considering three options when sitting down to hack vimprobable2 to my needs: maintain a patch series in a fashion you describe, somehow convince you to accept all my patches (unlikely), fork entirely (meh). > I don't have a comment on "Apture", as I don't care for it. But it will > need generalising further if it's to be considered upstream. I don't expect you to, to me that's me just hacking about with loading scripts into WebKit. What I /intend/ to do is generalize it out into "user-scripts" support, instructing vimprobable2 to load scripts from ${HOME}/.config/vimprobable/userscripts on each page view to get the desired effect. Part of my rationale with this is to include flash-block JavaScript with vimprobable2 which IMHO is an invaluable addition to any browser, especially since the flash-plugin exploits are exposing Linux users as well. > [1] I already have a patch to make the searchengines configurable via the > config file. Have you posted this to the list? I certainly wouldn't mind dropping my patch and just configuring my search engines. While I don't share the same sentiments towards Google as you, I normally use DuckDuckGo which meets my privacy no-tracking criteria (no ip logging, SSL, tor exit node, etc). I will send another paired down patchset when I get into the office of "the important stuff" for upstream and then keep my own patchset to myself :) - R. Tyler Croy -------------------------------------- GitHub: http://github.com/rtyler Twitter: http://twitter.com/agentdero -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: not available URL: From thomas at xteddy.org Thu Sep 30 20:15:12 2010 From: thomas at xteddy.org (Thomas Adam) Date: Thu, 30 Sep 2010 21:15:12 +0100 Subject: [Vimprobable-users] [PATCH 8/8] Disable Java by default In-Reply-To: <20100930133710.GC3810@kiwi.local> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-9-git-send-email-tyler@monkeypox.org> <20100930055732.GH15934@shuttle.home> <20100930133710.GC3810@kiwi.local> Message-ID: <20100930201510.GA2173@debian> On Thu, Sep 30, 2010 at 06:37:10AM -0700, R. Tyler Croy wrote: > > On Thu, 30 Sep 2010, Thomas Adam wrote: > > > On Wed, Sep 29, 2010 at 10:21:28PM -0700, R. Tyler Croy wrote: > > > Who uses Java applets? All Java (in vimprobable2 at least) seems to do > > > is destabilize the browser > > > > This isn't a rationale, it's a personal preference. > > > > In favour of rejecting this. > > What if this was changed to be a proper setting cohnfigurable via :set? In my > usage of vimprobable2, any time a Java applet is loaded into the WebView the > browser SIGSEGVs something nasty, thus the patch. Adding a patch to make this configurable via set is trivial, so by all means. But regardless of that, if what you say is true about SIGSERV, blindly turning it off (which amounts to nothing more than a case of sticking your fingers in your ears and going "la la la, I'm not listening") to avoid the problem is not the right solution. Diagnose the problem, don't hide it globally. If you can reproduce this, and you get a corefile, I'd appreciate a backtrace from it so we can diagnose it. > I can understand why you might not want Java to be disabled by default (Chrome > doesn't disable it either), but IMHO it should be an accessible setting at > least from the Vimprobablerc Sure -- the patch is trivial. Write one, or ask me to. > Would you accept a patch with an rc setting and defaulting to java enabled? I'd accept a patch for setting this via :set, but I don't want to see us starting to ship vimprobablerc files by default -- the user can do this at their behest. -- Thomas Adam -- "It was the cruelest game I've ever played and it's played inside my head." -- "Hush The Warmth", Gorky's Zygotic Mynci. From thomas at xteddy.org Thu Sep 30 20:19:02 2010 From: thomas at xteddy.org (Thomas Adam) Date: Thu, 30 Sep 2010 21:19:02 +0100 Subject: [Vimprobable-users] [PATCH 0/8] A few extensions to vimprobable2 In-Reply-To: <20100930134639.GD3810@kiwi.local> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <20100930060257.GI15934@shuttle.home> <20100930134639.GD3810@kiwi.local> Message-ID: <20100930201859.GB2173@debian> On Thu, Sep 30, 2010 at 06:46:39AM -0700, R. Tyler Croy wrote: > > On Thu, 30 Sep 2010, Thomas Adam wrote: > > > Hello -- > > > > On Wed, Sep 29, 2010 at 10:21:20PM -0700, R. Tyler Croy wrote: > > > > > > Forgive me for the patch spam to the list, I've got a few patches to the > > > latest release of vimprobable2 that I'm currentlly using. > > > > > > I recognize that some of the patches are likely not going to be desired > > > by most folks but I'm including them anyways (for posterity or some nonsense) > > > > Well, some of them are useful, such as the Makefile patches, and the > > gitignore patch. Please see my relevant replies to those threads. > > > > As for the others, I'm advocating to reject them. They can either be > > controlled via the vimprobablerc file, or fixed up locally by you. > > I'm totally cool with this, I wanted to sent the whole series along for two > reasons really: > > * Wanted to see what you/anybody thought of them in general > * Wanted you (upstream) maintainer to be aware of some of the changes/desires > that I (userguy) might have with regards to vimprobable2 Careful; I am not a maintainer or anything, I just send patches to improve it. > That's the general plan, I was considering three options when sitting down to > hack vimprobable2 to my needs: maintain a patch series in a fashion you > describe, somehow convince you to accept all my patches (unlikely), fork > entirely (meh). You could fork it, or just use Jumanji. ;) > Have you posted this to the list? I certainly wouldn't mind dropping my patch > and just configuring my search engines. While I don't share the same sentiments > towards Google as you, I normally use DuckDuckGo which meets my privacy > no-tracking criteria (no ip logging, SSL, tor exit node, etc). And scroogle (which is shipped by default) isn't sufficient for this because...? No, I've not sent the patch because it's sat directly on top of other, more fundamental changes I am still reviewing before I send them. Won't be long now though. -- Thomas Adam -- "It was the cruelest game I've ever played and it's played inside my head." -- "Hush The Warmth", Gorky's Zygotic Mynci. From hannes at yllr.net Thu Sep 30 20:32:42 2010 From: hannes at yllr.net (Hannes =?iso-8859-1?Q?Sch=FCller?=) Date: Thu, 30 Sep 2010 22:32:42 +0200 Subject: [Vimprobable-users] [PATCH 1/8] Instal manpages into the appropriate directory in ${PREFIX} In-Reply-To: <1285824088-30272-2-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-2-git-send-email-tyler@monkeypox.org> Message-ID: <20100930203241.GA2167@laptop2.lan.localhost> I have to confess I'm pretty much ignorant when it comes to recommended file system layout. I'm inclined to trust you here and accept this unless someone protests. Hannes -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: Digital signature URL: From hannes at yllr.net Thu Sep 30 20:33:24 2010 From: hannes at yllr.net (Hannes =?iso-8859-1?Q?Sch=FCller?=) Date: Thu, 30 Sep 2010 22:33:24 +0200 Subject: [Vimprobable-users] [PATCH 2/8] Adding an ignore file In-Reply-To: <1285824088-30272-3-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-3-git-send-email-tyler@monkeypox.org> Message-ID: <20100930203323.GB2167@laptop2.lan.localhost> This seems reasonable. Hannes -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: Digital signature URL: From hannes at yllr.net Thu Sep 30 20:35:50 2010 From: hannes at yllr.net (Hannes =?iso-8859-1?Q?Sch=FCller?=) Date: Thu, 30 Sep 2010 22:35:50 +0200 Subject: [Vimprobable-users] [PATCH 3/8] Change the default search engine and add encrypted Google Search In-Reply-To: <1285824088-30272-4-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-4-git-send-email-tyler@monkeypox.org> Message-ID: <20100930203550.GC2167@laptop2.lan.localhost> I don't think an upstream change is required here. Scroogle fills the Google needs, in my opinion, and changing the default homepage to anything but the Vimprobable website seems to be a pretty bad idea. Hannes -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: Digital signature URL: From hannes at yllr.net Thu Sep 30 20:39:54 2010 From: hannes at yllr.net (Hannes =?iso-8859-1?Q?Sch=FCller?=) Date: Thu, 30 Sep 2010 22:39:54 +0200 Subject: [Vimprobable-users] [PATCH 4/8] Make hints a bit more readable with black on yellow In-Reply-To: <1285824088-30272-5-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-5-git-send-email-tyler@monkeypox.org> Message-ID: <20100930203953.GD2167@laptop2.lan.localhost> On Wed, Sep 29, 2010 at 10:21:24PM -0700, R. Tyler Croy wrote: > IMHO white-on-red is too jarring with regards to contrast, > making it more difficult to see These colours have been inherited from Vimperator. The point, I think, is to make them as striking as possible, because the user has to *notice* the hints appearing. Aestetics, in my opinion, aren't a major concern here. Does anyone else have an opinion about this? Hannes -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: Digital signature URL: From hannes at yllr.net Thu Sep 30 20:47:41 2010 From: hannes at yllr.net (Hannes =?iso-8859-1?Q?Sch=FCller?=) Date: Thu, 30 Sep 2010 22:47:41 +0200 Subject: [Vimprobable-users] [PATCH 5/8] Use a more Chrome-looking user-agent to help vimprobable2 work with more sites In-Reply-To: <1285824088-30272-6-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-6-git-send-email-tyler@monkeypox.org> Message-ID: <20100930204740.GE2167@laptop2.lan.localhost> On Wed, Sep 29, 2010 at 10:21:25PM -0700, R. Tyler Croy wrote: > Too many important sites are using crappy browser detection, causing vimprobable2 > to have issues running their JS I think *defaulting* to a 'faked' user agent string is a very bad idea. Opera did this for a very long time and what did it achieve? They never even turned up in any usage statistics, but they where subsumed under Internet Explorer. So webmasters thought themselves save to 'optimise' for that browser alone. However, I do think you're bringing up quite an important topic here. The current user agent string is not really standards compliant. The problem is: What to put there by default? Neither the operating system, nor the processor architecture and least of all the Webkit version used are known in advance. Any suggestions on how to proceed here? Hannes -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: Digital signature URL: From hannes at yllr.net Thu Sep 30 20:49:32 2010 From: hannes at yllr.net (Hannes =?iso-8859-1?Q?Sch=FCller?=) Date: Thu, 30 Sep 2010 22:49:32 +0200 Subject: [Vimprobable-users] [PATCH 6/8] Add Apture's detached search by default In-Reply-To: <1285824088-30272-7-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-7-git-send-email-tyler@monkeypox.org> Message-ID: <20100930204931.GF2167@laptop2.lan.localhost> On Wed, Sep 29, 2010 at 10:21:26PM -0700, R. Tyler Croy wrote: > This is kind of a jerry-rigged version of the Apture Highlights plugin > for Chrome. This should probably be generalized to be easier to turn > off via userscripts support or something similar Sorry, but could you quickly summarise what the plugin you mentioned even does? I have no idea what 'Apture Highlights' are and the code certainly doesn't speak for itself. Hannes -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: Digital signature URL: From tyler at monkeypox.org Thu Sep 30 20:53:00 2010 From: tyler at monkeypox.org (R. Tyler Croy) Date: Thu, 30 Sep 2010 13:53:00 -0700 Subject: [Vimprobable-users] [PATCH 4/8] Make hints a bit more readable with black on yellow In-Reply-To: <20100930203953.GD2167@laptop2.lan.localhost> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-5-git-send-email-tyler@monkeypox.org> <20100930203953.GD2167@laptop2.lan.localhost> Message-ID: <20100930205300.GH4784@kiwi.sharlinx.com> On Thu, 30 Sep 2010, Hannes Sch?ller wrote: > On Wed, Sep 29, 2010 at 10:21:24PM -0700, R. Tyler Croy wrote: > > IMHO white-on-red is too jarring with regards to contrast, > > making it more difficult to see > > These colours have been inherited from Vimperator. The point, I think, > is to make them as striking as possible, because the user has to > *notice* the hints appearing. Aestetics, in my opinion, aren't a major > concern here. Does anyone else have an opinion about this? I actually borrowed the colors from Vimium (Chrome plugin) which I used when jumping ship from Vimperator to Chrome :P I have no preference with regards to this making it upstream or not, I will likely keep using these colors since the "striking"-ness of white on red hurts my eyes. For reference, this is how it looks: http://agentdero.cachefly.net/scratch/vp_hints.jpg - R. Tyler Croy -------------------------------------- GitHub: http://github.com/rtyler Twitter: http://twitter.com/agentdero -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: not available URL: From hannes at yllr.net Thu Sep 30 20:51:58 2010 From: hannes at yllr.net (Hannes =?iso-8859-1?Q?Sch=FCller?=) Date: Thu, 30 Sep 2010 22:51:58 +0200 Subject: [Vimprobable-users] [PATCH 7/8] Bump the font-size to make vimprobable2 a bit easier to read on bigger screens In-Reply-To: <1285824088-30272-8-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-8-git-send-email-tyler@monkeypox.org> Message-ID: <20100930205157.GG2167@laptop2.lan.localhost> I'm using a 22" screen and the current default is fine for me. Just like on my 12" notebook. Don't care much one way or the other. Hannes -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: Digital signature URL: From hannes at yllr.net Thu Sep 30 20:54:05 2010 From: hannes at yllr.net (Hannes =?iso-8859-1?Q?Sch=FCller?=) Date: Thu, 30 Sep 2010 22:54:05 +0200 Subject: [Vimprobable-users] [PATCH 8/8] Disable Java by default In-Reply-To: <1285824088-30272-9-git-send-email-tyler@monkeypox.org> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-9-git-send-email-tyler@monkeypox.org> Message-ID: <20100930205403.GH2167@laptop2.lan.localhost> On Wed, Sep 29, 2010 at 10:21:28PM -0700, R. Tyler Croy wrote: > Who uses Java applets? All Java (in vimprobable2 at least) seems to do > is destabilize the browser Eh... to be honest, I always assumed the 'plugins' setting covered Java as well. Personally, I don't even have Java installed, so it never occured to me this might be a different setting. Could you make a patch which makes this configurable via :set (with the default being 'on', just like the other plugins, Javascript and the rest of the crap)? I'd merge that for sure! Hannes -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: Digital signature URL: From tyler at monkeypox.org Thu Sep 30 20:58:06 2010 From: tyler at monkeypox.org (R. Tyler Croy) Date: Thu, 30 Sep 2010 13:58:06 -0700 Subject: [Vimprobable-users] [PATCH 6/8] Add Apture's detached search by default In-Reply-To: <20100930204931.GF2167@laptop2.lan.localhost> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-7-git-send-email-tyler@monkeypox.org> <20100930204931.GF2167@laptop2.lan.localhost> Message-ID: <20100930205806.GI4784@kiwi.sharlinx.com> On Thu, 30 Sep 2010, Hannes Sch?ller wrote: > On Wed, Sep 29, 2010 at 10:21:26PM -0700, R. Tyler Croy wrote: > > This is kind of a jerry-rigged version of the Apture Highlights plugin > > for Chrome. This should probably be generalized to be easier to turn > > off via userscripts support or something similar > > Sorry, but could you quickly summarise what the plugin you mentioned > even does? I have no idea what 'Apture Highlights' are and the code > certainly doesn't speak for itself. The plugin is here: https://chrome.google.com/extensions/detail/cppaadhnncohnjgallikmjdonfliciek I'd prefer, that you just pretended this patch didn't exist. I added it to give myself this functionality while I work on putting together a "userscripts" patch - R. Tyler Croy -------------------------------------- GitHub: http://github.com/rtyler Twitter: http://twitter.com/agentdero -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: not available URL: From thomas at xteddy.org Thu Sep 30 21:02:46 2010 From: thomas at xteddy.org (Thomas Adam) Date: Thu, 30 Sep 2010 22:02:46 +0100 Subject: [Vimprobable-users] [PATCH 5/8] Use a more Chrome-looking user-agent to help vimprobable2 work with more sites In-Reply-To: <20100930204740.GE2167@laptop2.lan.localhost> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-6-git-send-email-tyler@monkeypox.org> <20100930204740.GE2167@laptop2.lan.localhost> Message-ID: <20100930210241.GD2173@debian> On Thu, Sep 30, 2010 at 10:47:41PM +0200, Hannes Sch?ller wrote: > However, I do think you're bringing up quite an important topic here. > The current user agent string is not really standards compliant. The > problem is: What to put there by default? Neither the operating system, > nor the processor architecture and least of all the Webkit version used > are known in advance. Any suggestions on how to proceed here? ELinks does this by using substitution -- but even then, it's not compliant. There is no real compliance, you're free to put whatever you like in there. Hence, I don't think it's worth trying to update it to what the default is now -- it's not "compliant" in that it's not a Mozilla string, but then that's OK too, right? I think it's worth mentioning on vimprobable.org why this is -- and a likely UserAgent candidate for those who can't live without useragent parsing to make their websites work. -- Thomas Adam -- "It was the cruelest game I've ever played and it's played inside my head." -- "Hush The Warmth", Gorky's Zygotic Mynci. From tyler at monkeypox.org Thu Sep 30 21:07:41 2010 From: tyler at monkeypox.org (R. Tyler Croy) Date: Thu, 30 Sep 2010 14:07:41 -0700 Subject: [Vimprobable-users] [PATCH 5/8] Use a more Chrome-looking user-agent to help vimprobable2 work with more sites In-Reply-To: <20100930210241.GD2173@debian> References: <1285824088-30272-1-git-send-email-tyler@monkeypox.org> <1285824088-30272-6-git-send-email-tyler@monkeypox.org> <20100930204740.GE2167@laptop2.lan.localhost> <20100930210241.GD2173@debian> Message-ID: <20100930210740.GJ4784@kiwi.sharlinx.com> On Thu, 30 Sep 2010, Thomas Adam wrote: > On Thu, Sep 30, 2010 at 10:47:41PM +0200, Hannes Sch?ller wrote: > > However, I do think you're bringing up quite an important topic here. > > The current user agent string is not really standards compliant. The > > problem is: What to put there by default? Neither the operating system, > > nor the processor architecture and least of all the Webkit version used > > are known in advance. Any suggestions on how to proceed here? > > ELinks does this by using substitution -- but even then, it's not compliant. > There is no real compliance, you're free to put whatever you like in there. > > Hence, I don't think it's worth trying to update it to what the default is > now -- it's not "compliant" in that it's not a Mozilla string, but then > that's OK too, right? > > I think it's worth mentioning on vimprobable.org why this is -- and a likely > UserAgent candidate for those who can't live without useragent parsing to > make their websites work. I like this approach, "staying true" with the user-agent by default and then giving the rationale on the page, with a suggested user-agent string (perhaps even the command to set it) listed to help new users browse around without getting frustrated. It's incredible how many sites have JS that outright *breaks* when they don't understand the user-agent string. - R. Tyler Croy -------------------------------------- GitHub: http://github.com/rtyler Twitter: http://twitter.com/agentdero -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: not available URL: